fenestro-desktop/fenestro-about
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GTK3 code removal - part 1 #1

Closed
Sys_V_Anon wants to merge 4 commits from (deleted):master into master
pull from: (deleted):master
merge into: fenestro-desktop:master
Conversation 1 Commits 4 Files changed 4 +2 -162
Sys_V_Anon commented 2026-08-30 02:14:05 +00:00
Owner
Copy link

This is the beginning of the removal of the gtk3 code, revering back to gtk2. this has been done manually as I dont trust myself with automated tools. There's some checks I left behind on the files I touched that I'm unsure of.

Always happy to have a second set of eyes before merging!

This is the beginning of the removal of the gtk3 code, revering back to gtk2. this has been done manually as I dont trust myself with automated tools. There's some checks I left behind on the files I touched that I'm unsure of. Always happy to have a second set of eyes before merging!
Im not fully sure about some of these checks, so I'd like a second pair of eyes on the ones I left behind.
djk reviewed 2026-08-30 02:27:09 +00:00
djk left a comment
Copy link

A couple of quick comments.

A couple of quick comments.
libmate-desktop/mate-aboutdialog.c
@ -525,10 +511,6 @@ mate_about_dialog_init(MateAboutDialog *about)
gtk_window_set_resizable(GTK_WINDOW(about), FALSE);
#if !GTK_CHECK_VERSION(3, 0, 0)
djk commented 2026-08-30 02:23:41 +00:00
Owner
Copy link

This looks like it's for gtk2, not gtk3

This looks like it's for gtk2, not gtk3
libmate-desktop/mate-aboutdialog.c
@ -429,15 +429,7 @@ mate_about_dialog_init(MateAboutDialog *about)
5);
/* Widgets */
#if !GTK_CHECK_VERSION(3, 0, 0)
djk commented 2026-08-30 02:26:35 +00:00
Owner
Copy link

This also should be kept as it is not greater than v3.

This also should be kept as it is not greater than v3.
mate-about/mate-about.c
@ -59,7 +40,6 @@ mate_about_on_activate(GApplication *app)
}
}
#endif
djk commented 2026-08-30 02:25:25 +00:00
Owner
Copy link

This looks like it will leave behind an extra blank line. Can I get a clang-format -i **/*.c **/*.h run on the project before merging? (I'd like to get this check added to CI at some point, but I don't think we have runners yet...)

This looks like it will leave behind an extra blank line. Can I get a `clang-format -i **/*.c **/*.h` run on the project before merging? (I'd like to get this check added to CI at some point, but I don't think we have runners yet...)
Sys_V_Anon commented 2026-08-30 02:59:17 +00:00
Author
Owner
Copy link

@djk go for it man. That's why I asked for a second set of eyes.

Maybe if I learn how to use unifdef...

@djk go for it man. That's why I asked for a second set of eyes. Maybe if I learn how to use unifdef...
Sys_V_Anon closed this pull request 2026-08-30 15:33:20 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fenestro-desktop/fenestro-about!1
No description provided.